Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 98dbff9a65c4
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 1bf7f5f240a4
Choose a head ref
  • 3 commits
  • 2 files changed
  • 1 contributor

Commits on Apr 22, 2020

  1. srcOnly: fix invocation and document

    Previously, callPackage would try and fill the arguments such as `name`
    and `src` which would cause problems if those existed as top-level
    attributes. This also makes it clearer what part is the function
    signature.
    
    Then document the derivation inline in the code to explain the ellipsis
    and various use-cases.
    zimbatm committed Apr 22, 2020
    Copy the full SHA
    bbbc419 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2020

  1. srcOnly: rename buildInputs to nativeBuildInputs

    The only reason to pass build inputs is to extend the unpackPhase with
    custom unpack commands. Eg: add "unrar" to unpack rar sources. And those
    should really be passed as native build inputs. Why? Because
    nativeBuildInputs is for dependencies that are used at build time but
    will not propagate as runtime dependencies. And also, cross-compilation.
    zimbatm committed Apr 27, 2020
    Copy the full SHA
    31ead7d View commit details
    Browse the repository at this point in the history
  2. Merge pull request #85750 from zimbatm/srcOnly-docs

    srcOnly: fix invocation and document
    zimbatm committed Apr 27, 2020
    Copy the full SHA
    1bf7f5f View commit details
    Browse the repository at this point in the history