Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

processing: 3.5.3 -> 3.5.4 #91398

Merged
merged 1 commit into from Jun 29, 2020
Merged

processing: 3.5.3 -> 3.5.4 #91398

merged 1 commit into from Jun 29, 2020

Conversation

tasmo
Copy link
Contributor

@tasmo tasmo commented Jun 24, 2020

Motivation for this change

Updates the Processing software and its reference to the newest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

danieldk
danieldk suggested changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I added a suggested fix for a reproducibility issue.

This PR also has a merge commit, could you flatten it to one commit?

pkgs/applications/graphics/processing/default.nix Outdated Show resolved Hide resolved
@tasmo
Copy link
Contributor Author

tasmo commented Jun 25, 2020

Thank you for the change request! I had to force push as the merge after my changes had to many changes. Didn't know how to do softer.

@danieldk danieldk self-requested a review June 26, 2020 13:34
@nh2
Copy link
Contributor

nh2 commented Jun 28, 2020

Result of nixpkgs-review pr 91398 1

1 package failed to build:
- processing

@tasmo
Copy link
Contributor Author

tasmo commented Jun 29, 2020

Result of nixpkgs-review pr 91398 1
1 package failed to build:

  • processing

Unfortunately I cannot reproduce the error. Can you give some more details please.

@nh2
Copy link
Contributor

nh2 commented Jun 29, 2020 •
edited

Unfortunately I cannot reproduce the error. Can you give some more details please.

Sorry, this is just what nixpkgs-review says. I checked and the actual error is that the Oracle Java SDK is unfree and that I should download it manually, so may not be an error. (But the nixpkgs-review that I kicked off posts the result on the PR even then).

So I didn't actually manage to test :) and am happy if it works for you / @danieldk.

@danieldk
Copy link
Contributor

danieldk commented Jun 29, 2020 •
edited

I ran into the same problem. The PR looks good to me, but I don't want to install the Oracle JDK 8 given its new draconian license terms, so I cannot really test it properly.

@tasmo
Copy link
Contributor Author

tasmo commented Jun 29, 2020

OK, I understand that. I also had trouble to install the Oracle JDK. This thread helped me: https://gist.github.com/wavezhang/ba8425f24a968ec9b2a8619d7c2d86a6

In the forums about using Processing with OpenJDK I saw that it only works properly with Oracle. I do not like this fact either.

@nh2
Copy link
Contributor

nh2 commented Jun 29, 2020

Merging given that the diff looks good, and @tasmo has tested the execution.

As far as I understand, only processing4 will support OpenJDK, see benfry/processing4#1.

@nh2 nh2 merged commit 625f6b2 into NixOS:master Jun 29, 2020
@Pacman99 Pacman99 mentioned this pull request Aug 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk Awaiting requested review from danieldk

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tasmo @nh2 @danieldk