New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
octoprint: freeze deps and fix build #91417
Conversation
@elohmeier Does |
@elohmeier that's been an issue with that package for months. I disabled python38 since it was causing me to not be able to review many packages. but was effectively reverted in 364909d , although i think it was able to build fine after this ... not sure when it started pausing again |
@jonringer I don't think disabling |
Sorry, didn't mean to close the PR. Just clicked on the wrong button. @jonringer This should fix uvloop: #91440 |
The commit was from January, long before the (python3 -> python38) switch. And I did it so that I could review other packages, I agree it's not a great fix eitiher |
I've merged master. Now it fails in |
please avoid merge commits, it's prefered to do:
over
|
a9d9e82
to
707f3ef
Compare
@gebner Thanks for the fix to uvloop, I've rebased onto the latest master containing your changes. The octoprint build still fails because of conflicting dependency versions, e.g.:
I'm not sure how to override them correctly so that they are modified in the transient dependencies. @jonringer do you have an idea how to do that? |
707f3ef
to
5cd7900
Compare
You can look at https://github.com/NixOS/nixpkgs/blob/master/pkgs/tools/admin/awscli/default.nix . This might cause issues, as the package that's bringing in the other werkzeug version likely will needed be patch to accept a different version range. |
5cd7900
to
4afa270
Compare
Got it fixed now. I had to introduce trytond as a python package, so that the packageOverrides can be applied to it. This PR should be ready to be merged now. |
Thanks for your help @gebner & @jonringer! |
Adding Is it possible to make the Edit: Just moving it from Edit 2: #94082 |
Motivation for this change
Octoprint requires an older version of Werkzeug than in nixpkgs, causing a build failure. This pins the dependency version using the already established approach in the octoprint package and fixes the build.
Also the other build dependencies were fixed.
Things done
Pinned and fixed dependencies.
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)