Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bully: 1.1 -> 1.4-00 #91386

Merged
merged 1 commit into from Jul 2, 2020
Merged

bully: 1.1 -> 1.4-00 #91386

merged 1 commit into from Jul 2, 2020

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Add documentation and minor cleanups.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from edwtjo June 24, 2020 00:58
@peterhoeg
Copy link
Member Author

peterhoeg commented Jun 29, 2020 via email

@peterhoeg
Copy link
Member Author

@Ma27 - any other concerns?

@Ma27
Copy link
Member

Ma27 commented Jul 1, 2020

@peterhoeg the openssl attr is overridden in all-packages.nix:

{
 # ...

  bully = callPackage ../tools/networking/bully {
    openssl = openssl_1_0_2;
  };
}

@peterhoeg
Copy link
Member Author

Thanks @Ma27. Even better, bully has been updated to no longer require openssl. It is however not in a released version.

@peterhoeg peterhoeg mentioned this pull request Jul 2, 2020
Closed
@peterhoeg peterhoeg changed the title bully: add documentation bully: 1.1 -> 1.4-00 Jul 2, 2020
@peterhoeg
Copy link
Member Author

New (maintained) upstream.

@peterhoeg
bully: 1.1 -> 1.4-00
772ce9d 
New maintained upstream.
@peterhoeg
Copy link
Member Author

peterhoeg commented Jul 2, 2020 via email

@Ma27
Copy link
Member

Ma27 commented Jul 2, 2020

Thanks for taking care of this! Unless someone's faster I can review/merge tonight.

@Ma27 Ma27 merged commit 270eb78 into master Jul 2, 2020
@Ma27 Ma27 deleted the clean/bully branch July 2, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h left review comments

@Ma27 Ma27 Ma27 approved these changes

@edwtjo edwtjo Awaiting requested review from edwtjo

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterhoeg @Ma27 @cole-h