Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.hsimport: unbreak #91388

Merged
merged 1 commit into from Jun 24, 2020
Merged

Conversation

svmhdvn
Copy link
Contributor

@svmhdvn svmhdvn commented Jun 24, 2020

Motivation for this change

Marking hsimport unbroken after bumping dependency upper bound in upstream fendor/hsimport#33.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cdepillabout
Copy link
Member

Thanks! Looks like hsimport builds now!

@cdepillabout cdepillabout merged commit 996d6e7 into NixOS:haskell-updates Jun 24, 2020
@svmhdvn svmhdvn deleted the patch-1 branch June 24, 2020 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants