Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/generic-extlinux-compatible: fix docbook syntax #91371

Merged
merged 1 commit into from Jun 23, 2020
Merged

nixos/generic-extlinux-compatible: fix docbook syntax #91371

merged 1 commit into from Jun 23, 2020

Conversation

B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Jun 23, 2020

Motivation for this change

Fix invalid docbook syntax introduced by #91195.

options-docbook.xml.drv-log 
intermediate.xml:772: parser error : Opening and ending tag mismatch: path-to-default-configuration line 769 and para
</para></nixos:option-description><para><emphasis>Type:</emphasis> string <empha
       ^
intermediate.xml:772: parser error : Opening and ending tag mismatch: para line 769 and nixos:option-description
</para></nixos:option-description><para><emphasis>Type:</emphasis> string <empha
                                  ^
intermediate.xml:774: parser error : Opening and ending tag mismatch: option-description line 769 and listitem
            </filename></member></simplelist></listitem></varlistentry><varliste
                                                        ^
intermediate.xml:774: parser error : Opening and ending tag mismatch: listitem line 769 and varlistentry
            </filename></member></simplelist></listitem></varlistentry><varliste
                                                                       ^
intermediate.xml:72188: parser error : Opening and ending tag mismatch: varlistentry line 769 and variablelist
      </filename></member></simplelist></listitem></varlistentry></variablelist>
                                                                               ^
intermediate.xml:72188: parser error : Opening and ending tag mismatch: variablelist line 769 and appendix
lename></member></simplelist></listitem></varlistentry></variablelist></appendix
                                                                               ^
intermediate.xml:72190: parser error : EndTag: '</' not found

^
unable to parse intermediate.xml
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

CC @flokli

@flokli
Copy link
Contributor

flokli commented Jun 23, 2020

Urgh, sorry - thanks for spotting this so quickly.

@flokli flokli merged commit 6c1b896 into NixOS:master Jun 23, 2020
@B4dM4n B4dM4n deleted the generic-extlinux-compatible-docbook branch June 23, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@B4dM4n @flokli