Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discord: fix appindicator tray icon support #91375

Merged
merged 1 commit into from Jun 24, 2020

Conversation

benley
Copy link
Member

@benley benley commented Jun 23, 2020

Include libappindicator-gtk3 in discord's library path so it's able to create an indicator icon.

Motivation for this change

Appindicator / system tray icon wasn't working for Discord. Found an explanation at electron/electron#10427 of the need for libappindicator-gtk3, and this indeed seems to fix the problem.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Include libappindicator-gtk3 in discord's library path so it's able to
create an indicator icon.
@benley
Copy link
Member Author

benley commented Jun 23, 2020

note: this should also be backported to nixos 20.03

Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Tested with GNOME 3, the appindicator now works great.

Result of nixpkgs-review pr 91375 1

3 packages built:
- discord
- discord-canary
- discord-ptb

@danieldk danieldk merged commit f21e6f1 into NixOS:master Jun 24, 2020
@benley benley added the 9.needs: port to stable A PR needs a backport to the stable release. label Jun 25, 2020
@benley benley deleted the benley/discord-systray branch August 23, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants