Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromium: 83.0.4103.106 -> 83.0.4103.116 #91392

Merged
merged 1 commit into from Jun 24, 2020
Merged

chromium: 83.0.4103.106 -> 83.0.4103.116 #91392

merged 1 commit into from Jun 24, 2020

Conversation

thefloweringash
Copy link
Member

@thefloweringash thefloweringash commented Jun 24, 2020 •
edited by primeos

https://chromereleases.googleblog.com/2020/06/stable-channel-update-for-desktop_22.html

This update includes 2 security fixes.

CVEs: CVE-2020-6509

Testing status
platform attribute status tester
x86_64 chromium ✔️ @danielfullmer
x86_64 nixosTests.chromium ✔️ @danielfullmer
x86_64 google-chrome ✔️ @primeos
aarch64 chromium ✔️ @thefloweringash
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@thefloweringash
Copy link
Member Author

Built chromium and nix-build nixos/tests/chromium.nix -A stable on aarch64.

@primeos
Copy link
Member

primeos commented Jun 24, 2020

google-chrome still works and I didn't notice any regressions. And thanks for taking care of this update @thefloweringash (I was away yesterday).

@primeos primeos added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Jun 24, 2020
danielfullmer
danielfullmer approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@danielfullmer danielfullmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested chromium and nixosTests.chromium on x86_64-linux.

@primeos primeos merged commit a7fa6f6 into NixOS:master Jun 24, 2020
@primeos primeos mentioned this pull request Jun 24, 2020
Merged
10 tasks
@thefloweringash thefloweringash deleted the chromium branch June 25, 2020 08:05
@TredwellGit TredwellGit added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielfullmer danielfullmer danielfullmer approved these changes

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thefloweringash @primeos @danielfullmer @TredwellGit