Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-okta: 0.26.3 -> 1.0.2 #91400

Merged
merged 3 commits into from Jun 25, 2020
Merged

aws-okta: 0.26.3 -> 1.0.2 #91400

merged 3 commits into from Jun 25, 2020

Conversation

timstott
Copy link
Contributor

@timstott timstott commented Jun 24, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
      • Tested aws-okta -d add ✔️
      • Tested aws-okta version ✔️
      • Tested aws-okta exec ✔️
    • macOS
      • Tested aws-okta -d add ✔️
      • Tested aws-okta version ✔️
      • Tested aws-okta exec ✔️
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • Before
      nix path-info -h -S ./result
      /nix/store/2fpl97qijbqyp9z25ag03mv9y0d40w9f-aws-okta-0.26.3       50.2M
      
    • After
      nix path-info -h -S ./result
      /nix/store/ga0rdb9347rg22ia51cmyvngskcxwvy1-aws-okta-1.0.2        47.3M
      
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants