Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow DXF import of 3D arcs and circles #640

Merged
merged 1 commit into from Oct 1, 2020
Merged

Allow DXF import of 3D arcs and circles #640

merged 1 commit into from Oct 1, 2020

Conversation

johreh
Copy link
Contributor

@johreh johreh commented Jun 23, 2020

Extrusion direction (normal) of arcs and circles were not taken into
account when importing.

  • Add method for calculating a quaternion from extrusion direction
    according to DXF arbitrary axis algorithm
  • Add required workplanes for arcs not on XY origin plane
  • Adjust addDimRadial and addDimDiametric to include normal when
    creating associated circle request

@CLAassistant
Copy link

CLAassistant commented Jun 23, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@johreh
Copy link
Contributor Author

johreh commented Jun 23, 2020

Fix for #629
Not that it might be prudent to merge pull request solvespace/libdxfrw#13 before this one since it otherwise won't import 3D circle-constraints correctly. It also makes it possible to remove the temporary copies in those methods.

@johreh johreh mentioned this pull request Jun 23, 2020
Closed
@johreh
Allow DXF import of 3D arcs and circles
aaaa567 
Extrusion direction (normal) of arcs and circles were not taken into
account when importing.

- Add method for calculating a quaternion from extrusion direction
  according to DXF arbitrary axis algorithm
- Add required workplanes for arcs not on XY origin plane
- Adjust addDimRadial and addDimDiametric to include normal when
  creating associated circle request
@whitequark
Copy link
Contributor

Code looks essentially reasonable, I'll take a closer look again later. Can you attach a few files you're testing this on?

@phkahler
Copy link
Member

@johreh As I recall this worked, but I am unable to compile locally after applying the patch now. Seems to be related to the libdxfrw change, but that looks like it got merged. It passed the CI test though so I'm not sure what to make of the situation.

@johreh
Copy link
Contributor Author

johreh commented Sep 23, 2020

@phkahler I just tried rebuilding this rebased on top of latest master. I did not get any build errors.

@whitequark Oops, forgot about this. I'll try to find some of the files I used.

@phkahler phkahler merged commit 3ce8c29 into solvespace:master Oct 1, 2020
@phkahler phkahler linked an issue Oct 1, 2020 that may be closed by this pull request
SolveSpace won't import 3D circles/arcs from DXF #629
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SolveSpace won't import 3D circles/arcs from DXF
4 participants
@johreh @CLAassistant @whitequark @phkahler