Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ytree: init at 2.02 #91373

Merged
merged 1 commit into from Jun 25, 2020
Merged

ytree: init at 2.02 #91373

merged 1 commit into from Jun 25, 2020

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Jun 23, 2020 •
edited

ytree is a simple file manager, inspired in the venerable DOS xtree command.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

iblech
iblech approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@iblech iblech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, thanks for packaging this! I confirm that your build works here. :-)

I had a quick look at the Debian patches for ytree. The ncurses header change looks potentially relevant, but I don't really know. In any case, I didn't notice any graphical glitches with file names containing umlauts or emojis. Cool that we package a newer version than Debian. :-)

We could make the build more reproducible by substituing gzip in the Makefile by gzip -n, as in this commit. This way the current time won't find its way into the gzipped files.

pkgs/tools/misc/ytree/default.nix Outdated
version = "2.02";

src = fetchurl {
url = "https:/han.de/~werner/${pname}-${version}.tar.gz";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be https://, not https:/ :-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh man!

@iblech
Copy link
Contributor

iblech commented Jun 24, 2020

Actually please disregard the suggestions regarding reproducibility. The situation with the linked commit was different, there the files to be gzipped have been dynamically created by the make process. Here they are part of the source archive and hence already have a fixed timestamp.

@AndersonTorres
Copy link
Member Author

As far as I have seen on Nixpkgs, ncurses is already with wide support. I will use it explicitly.

And I will use the gzip option anyway. It will not hurt anyone, after all.

@AndersonTorres
ytree: init at 2.02
0757cd4 
ytree is a simple file manager, inspired in the venerable DOS xtree command.
@AndersonTorres AndersonTorres merged commit 435963c into NixOS:master Jun 25, 2020
@AndersonTorres AndersonTorres deleted the create-ytree branch June 25, 2020 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iblech iblech iblech approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AndersonTorres @iblech