csr.event: add event monitor. #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 6 +1
Lines 630 675 +45
Branches 140 142 +2
=========================================
+ Hits 630 675 +45
Continue to review full report at Codecov.
|
jfng
commented
Jun 24, 2020
| @@ -0,0 +1,106 @@ | |||
| # nmigen: UnusedElaboratable=no | |||
There was a problem hiding this comment.
Disabling the warning in test_csr_event.py is not enough, because self._mux elaboratable defined in .__init__() would also be unused. So I disabled it here too.
whitequark
approved these changes
Jun 25, 2020
|
Great work, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for a CSR-capable version of
event.Monitor.