Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] mp4v2: 2.0.0 -> 4.1.3 #91402

Merged
merged 1 commit into from Jun 25, 2020
Merged

[20.03] mp4v2: 2.0.0 -> 4.1.3 #91402

merged 1 commit into from Jun 25, 2020

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Jun 24, 2020 •
edited by ckauhaus

Motivation for this change

This switches to a new upstream for mp4v2. I searched the git logs and the commit message indicate that the following CVEs are fixed:

Given the CVEs, this should probably be backported to 20.03.

Also see: #90888

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Anton-Latukha @danieldk
mp4v2: 2.0.0 -> 4.1.3
78e2687 
Switch into maintanable fork. It is the community central fork.

Remove old patch, use new minor upstream patch to compile.

I weighted-in on the patch reasoning to be merged.

Strictify hardening.

Documentation update

M  pkgs/development/libraries/mp4v2/default.nix

(cherry picked from commit c281c84)
@ofborg ofborg bot requested a review from Anton-Latukha June 24, 2020 11:20
@Anton-Latukha
Copy link
Contributor

@GrahamcOfBorg build mp4v2

@ckauhaus ckauhaus merged commit 3dbed61 into NixOS:release-20.03 Jun 25, 2020
@danieldk danieldk deleted the mp4v2 branch June 25, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anton-Latukha Anton-Latukha Anton-Latukha approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @Anton-Latukha @ckauhaus