Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2738ca86bd62
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d6cf34ea5a30
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on May 28, 2020

  1. metals: provide client-agnostic flavor

    @timokau
    timokau committed May 28, 2020
    Copy the full SHA
    0e2456d View commit details

  2. Merge pull request #89115 from timokau/metals-client-agnostic 

    metals: provide client-agnostic flavor
    @timokau
    timokau authored May 28, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    d6cf34e View commit details
Showing with 7 additions and 0 deletions.
  1. +7 −0 pkgs/development/tools/metals/default.nix
7 changes: 7 additions & 0 deletions pkgs/development/tools/metals/default.nix
View file
Original file line number Diff line number Diff line change
@@ -31,6 +31,13 @@ stdenv.mkDerivation rec {
installPhase = ''
mkdir -p $out/bin
# This variant is not targeted at any particular client, clients are
# expected to declare their supported features in initialization options.
makeWrapper ${jre}/bin/java $out/bin/metals \
--prefix PATH : ${lib.makeBinPath [ jdk ]} \
--add-flags "${extraJavaOpts} -cp $CLASSPATH scala.meta.metals.Main"
# Further variants targeted at clients with featuresets pre-set.
makeWrapper ${jre}/bin/java $out/bin/metals-emacs \
--prefix PATH : ${lib.makeBinPath [ jdk ]} \
--add-flags "${extraJavaOpts} -Dmetals.client=emacs -cp $CLASSPATH scala.meta.metals.Main"