Skip to content

Add Digilent Genesys2 board #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 28, 2020
Merged

Add Digilent Genesys2 board #49

merged 7 commits into from
May 28, 2020
+373 −0

Conversation

peteut
Copy link
Contributor

@peteut peteut commented Feb 29, 2020

The Blinky test works fine on my board.

peteut added 4 commits January 2, 2020 02:42
@peteut
Add Digilent Genesys2 board.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
kalbasit Wael Nasreddine
GPG key ID: FD437548E0BF0F5F
Expired
Verified
Learn about vigilant mode
cfa4449
@peteut
genesys2.py: fix typo.
9fc2f13
@peteut
genesys2: increase JTAG clock speed to 25 MHz.
ac44fa3
@peteut
Merge remote-tracking branch 'origin/upstream-master' into nmigen-boa…
95f3737 
…rds-1-master
@peteut peteut mentioned this pull request Feb 29, 2020
Closed
whitequark
whitequark requested changes Mar 21, 2020
View reviewed changes
peteut added a commit to peteut/nmigen-boards that referenced this pull request May 3, 2020
@peteut
genesys2: updates as proposed, refer to amaranth-lang#49.
39a0337
peteut added a commit to peteut/nmigen-boards that referenced this pull request May 3, 2020
@peteut
genesys2: updates as proposed, refer to amaranth-lang#49.
5642572
@peteut peteut force-pushed the nmigen-boards-1-master branch from 39a0337 to 5642572 Compare May 3, 2020 20:56
peteut added a commit to peteut/nmigen-boards that referenced this pull request May 3, 2020
@peteut
genesys2: updates as proposed, refer to amaranth-lang#49.
4144f1f
@peteut peteut force-pushed the nmigen-boards-1-master branch from 5642572 to 4144f1f Compare May 3, 2020 21:09
peteut added a commit to peteut/nmigen-boards that referenced this pull request May 3, 2020
@peteut
genesys2: updates as proposed, refer to amaranth-lang#49.
b2eb2ef
@peteut peteut force-pushed the nmigen-boards-1-master branch from 4144f1f to b2eb2ef Compare May 3, 2020 21:14
peteut added a commit to peteut/nmigen-boards that referenced this pull request May 3, 2020
@peteut
genesys2: updates as proposed, refer to amaranth-lang#49.
05aa15e
@peteut peteut force-pushed the nmigen-boards-1-master branch from b2eb2ef to 05aa15e Compare May 3, 2020 21:17
peteut added a commit to peteut/nmigen-boards that referenced this pull request May 3, 2020
@peteut
genesys2: updates as proposed, refer to amaranth-lang#49.
d8536dd
@peteut peteut force-pushed the nmigen-boards-1-master branch from 05aa15e to d8536dd Compare May 3, 2020 21:20
peteut added a commit to peteut/nmigen-boards that referenced this pull request May 4, 2020
@peteut
genesys2: updates as proposed, refer to amaranth-lang#49.
62ea747
@peteut peteut force-pushed the nmigen-boards-1-master branch from d8536dd to 62ea747 Compare May 4, 2020 00:16
@peteut peteut force-pushed the nmigen-boards-1-master branch from 62ea747 to b666383 Compare May 4, 2020 00:22
@peteut peteut requested a review from whitequark May 4, 2020 00:43
whitequark
whitequark requested changes May 8, 2020
View reviewed changes
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes! There are a few more things I'd like you to change though.

nmigen_boards/genesys2.py Outdated
Subsignal("scl", Pins("AE19", dir="io")),
Subsignal("sda", Pins("AF18", dir="io")),
Attrs(IOSTANDARD="LVCMOS18")),
Resource("oled", 0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What interface does the display actually implement? SPI?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whitequark it's an SPI interface w/o cs and miso pins. SPIResource expects those pins to be present. How should I tackle this?

peteut added a commit to peteut/nmigen-boards that referenced this pull request May 11, 2020
@peteut
genesys2: cleanup, refer to amaranth-lang#49. WIP.
06692df
peteut added a commit to peteut/nmigen-boards that referenced this pull request May 14, 2020
@peteut
genesys2: cleanup, refer to amaranth-lang#49. WIP.
600ab69
@peteut peteut force-pushed the nmigen-boards-1-master branch from 06692df to 600ab69 Compare May 14, 2020 17:51
peteut added a commit to peteut/nmigen-boards that referenced this pull request May 17, 2020
@peteut
genesys2: cleanup, refer to amaranth-lang#49. WIP.
6faf19b
@peteut peteut force-pushed the nmigen-boards-1-master branch from 600ab69 to 6faf19b Compare May 17, 2020 09:13
peteut added a commit to peteut/nmigen-boards that referenced this pull request May 17, 2020
@peteut
genesys2: cleanup, refer to amaranth-lang#49. WIP.
c8ac365
@peteut peteut force-pushed the nmigen-boards-1-master branch from 6faf19b to c8ac365 Compare May 17, 2020 09:16
peteut added a commit to peteut/nmigen-boards that referenced this pull request May 17, 2020
@peteut
genesys2: cleanup, refer to amaranth-lang#49. WIP.
ebc34d8
@peteut peteut force-pushed the nmigen-boards-1-master branch from c8ac365 to ebc34d8 Compare May 17, 2020 09:41
peteut added a commit to peteut/nmigen-boards that referenced this pull request May 17, 2020
@peteut
genesys2: cleanup, refer to amaranth-lang#49. WIP.
0565d18
@peteut peteut force-pushed the nmigen-boards-1-master branch from ebc34d8 to 0565d18 Compare May 17, 2020 10:08
peteut added a commit to peteut/nmigen-boards that referenced this pull request May 17, 2020
@peteut
genesys2: cleanup, refer to amaranth-lang#49. WIP.
2dc043c
@peteut peteut force-pushed the nmigen-boards-1-master branch from 0565d18 to 2dc043c Compare May 17, 2020 10:18
peteut added a commit to peteut/nmigen-boards that referenced this pull request May 17, 2020
@peteut
genesys2: cleanup, refer to amaranth-lang#49. WIP.
1dc1846
@peteut peteut force-pushed the nmigen-boards-1-master branch from 2dc043c to 1dc1846 Compare May 17, 2020 10:27
@peteut peteut force-pushed the nmigen-boards-1-master branch from 1dc1846 to a4ebe5a Compare May 17, 2020 10:39
@whitequark whitequark merged commit 86ae791 into amaranth-lang:master May 28, 2020
@whitequark
Copy link
Member

Thank you for your patience! All looks good to me now.

Sorry, something went wrong.

@peteut peteut deleted the nmigen-boards-1-master branch May 28, 2020 05:59
@igrr igrr mentioned this pull request Jun 8, 2020
Closed
rroohhh pushed a commit to rroohhh/nmigen-boards that referenced this pull request Aug 4, 2020
@whitequark
hdl.ast: fix typo.
81ee2db 
Fixes amaranth-lang#49.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitequark whitequark

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peteut @whitequark