Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.skein: init at 0.8.0 #89099

Merged
merged 4 commits into from Jun 19, 2020
Merged

python3Packages.skein: init at 0.8.0 #89099

merged 4 commits into from Jun 19, 2020

Conversation

alexbiehl
Copy link
Contributor

@alexbiehl alexbiehl commented May 28, 2020 •
edited

Motivation for this change

This PR adds the skein package to python3Modules. The build process is a bit hairy as it depends on an integrated Maven build from within the setup.py. I pulled it out and build the JAR separately and made the fetching of the Java dependencies into a fixed output derivation.

The Maven build downloads some native executables for dealing with ProtocolBuffer generation and thus needs some patchelf magic which further complicates the build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alexbiehl alexbiehl requested a review from jonringer May 29, 2020 06:17
@alexbiehl
Copy link
Contributor Author

@jonringer can you give this PR a second look?

@jonringer
Copy link
Contributor

cc @FRidh

@alexbiehl @jonringer
Apply @jonringers suggestions
a5bdbb8 
Co-authored-by: Jon <jonringer@users.noreply.github.com>
@alexbiehl
Copy link
Contributor Author

Thank you for your suggestions @jonringer! All of them applied!

@alexbiehl
Copy link
Contributor Author

Gentle ping for another round of reviews @jonringer @FRidh

@alexbiehl alexbiehl requested a review from jonringer June 19, 2020 16:08
imalsogreg
imalsogreg approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@imalsogreg imalsogreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I'd love to use this at work, any timeline for merge?

@shlevy shlevy merged commit 2590885 into NixOS:master Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlevy shlevy shlevy approved these changes

@imalsogreg imalsogreg imalsogreg approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alexbiehl @jonringer @shlevy @imalsogreg