Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mesa: 20.0.2 -> 20.0.7 #89105

Merged
merged 1 commit into from Jun 7, 2020
Merged

mesa: 20.0.2 -> 20.0.7 #89105

merged 1 commit into from Jun 7, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented May 28, 2020

Motivation for this change

Note: It's probably best to wait for 20.0.8 with is the last planned release for 20.0 as it should be released very soon (was scheduled for yesterday).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

version = "20.0.2";
# Release calendar: https://www.mesa3d.org/release-calendar.html
# Release frequency: https://www.mesa3d.org/releasing.html#schedule
version = "20.0.7"; # Update only to the final (last planned) release (i.e. X.Y.MAX)?
Copy link
Member Author

@primeos primeos May 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vcunat what do you think of the idea to only update to the final (last planned) release of a X.Y series?

This isn't ideal, but since we currently lack the capacity to update mesa ~every two weeks, our channels are usually delayed by a few days anyway, and this causes lots of rebuilds that sounded like an idea that might be worth a try. My hope is that the last/final release a a series would be the most bug free / well tested.
Gentoo might do this as well (https://packages.gentoo.org/packages/media-libs/mesa) but most distributions seem to package the most recent stable release.
But of course this wouldn't have to be a strict rule (sometimes we might e.g. require an update to fix other packages that run into bugs or require new features).

New features releases (new X.Y series) are available approx. every 3 months so that wouldn't be a problem for us, but it's unfortunately also a bit long.

Alternatives:

  • We could follow all stable updates if testing from @GrahamcOfBorg would be sufficient (the build time might e.g. be sufficient for a glxgears test if that runs with software drivers - haven't looked into that yet).
  • We keep the "random" updates (currently done) - i.e. someone updates mesa whenever they feel like the package is too outdated
  • We create a team for mesa and rotate for each update

Edit: Maybe I should also create an issue for this question?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the non-feature bumps I expect we could go without manual testing (into staging), in which case the update is quite easy to do. I also had some ideas about reducing the rebuild amounts significantly, at the very least on non-feature bumps (I could try to recover the ideas). But perhaps there's no real demand for frequent updates anyway?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, the rebuild ideas are here: #44831

pkgs/development/libraries/mesa/default.nix Show resolved Hide resolved
pkgs/development/libraries/mesa/default.nix Show resolved Hide resolved
@primeos
Copy link
Member Author

primeos commented May 28, 2020

I'll assign 9.needs: community feedback for #89105 (comment).

@FRidh FRidh added this to WIP in Staging via automation May 28, 2020
@vcunat
Copy link
Member

vcunat commented May 31, 2020

OK, at least this time I'd wait if .8 comes out in the next few days. We probably won't have a staging -> staging-next merge in the meantime anyway.

EDIT: still not available, as of June 7.

Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's stage this now; I can't see any benefit in waiting so long.

Staging automation moved this from WIP to Ready Jun 7, 2020
@vcunat vcunat merged commit 04b1ed0 into NixOS:staging Jun 7, 2020
Staging automation moved this from Ready to Done Jun 7, 2020
vcunat added a commit that referenced this pull request Jun 13, 2020
https://lists.freedesktop.org/archives/mesa-dev/2020-June/224501.html
/cc PR #89105; this is indeed announced to be the last 20.0 version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants