Fix: Set notificationpendingsince for dependent builds #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`build_finished` Postgres event will never be fired for the dependent builds. For example, on our Hydra, the following query always returns increasing numbers, even though all notifications have been delivered: ``` hydra=> select count(1) from builds where notificationpendingsince is not null; count ------- 4583 (1 row) ``` Thus, we have to iterate over all dependent builds and mark their `notificationpendingsince` as `null`, otherwise they will pile up until the next restart of hydra-notify, when they will get delivered.
knl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build_finishedPostgres event will never be fired for the dependent builds.For example, on our Hydra, the following query always returns increasing
numbers, even though all notifications have been delivered:
Thus, we have to iterate over all dependent builds and mark their
notificationpendingsinceasnull, otherwise they will pile up untilthe next restart of hydra-notify, when they will get delivered.