Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unbound: 1.10.0 -> 1.10.1 #89079

Closed
wants to merge 1 commit into from
Closed

Unbound: 1.10.0 -> 1.10.1 #89079

wants to merge 1 commit into from

Conversation

hmenke
Copy link
Member

@hmenke hmenke commented May 28, 2020

Motivation for this change
  • CVE-2020-12662 Unbound can be tricked into amplifying an incoming query into a large number of queries directed to a target.
  • CVE-2020-12663 Malformed answers from upstream name servers can be used to make Unbound unresponsive.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hmenke
Copy link
Member Author

hmenke commented May 28, 2020

This change will have to be backported to 20.03 as well. I've read CONTRIBUTING.md on that matter and I think I can do that, but it seems that this PR has to be merged first for this.

@hmenke
Copy link
Member Author

hmenke commented May 28, 2020

@ehmry @fpletz @globin

@ofborg ofborg bot requested review from fpletz, ehmry and globin May 28, 2020 05:19
@zowoq
Copy link
Contributor

zowoq commented May 28, 2020 •
edited

1.10.1 is in staging-next and release-20.03, it should be available via channels soon.

cc @vcunat

@vcunat vcunat closed this May 28, 2020
@hmenke hmenke deleted the unbound branch May 28, 2020 07:36
@hmenke
Copy link
Member Author

hmenke commented May 28, 2020 •
edited

Sorry for wasting everyone's time. I'll check better next time.

@vcunat
Copy link
Member

vcunat commented May 28, 2020

Large rebuilds are harder in this. The PR is closed before the changes hit master and sometimes that delay is significant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

@ehmry ehmry Awaiting requested review from ehmry

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
2.status: duplicate 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hmenke @zowoq @vcunat @Janik-Haag