python3Packages.diagrams: init at 0.12.0 #89127
Closed
+80
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: python
8.has: package (new)
costrouc
force-pushed
the
python-diagrams-init
branch
from
6f5573a to
f9c57ff
Compare
jonringer
reviewed
May 28, 2020
Comment on lines
+71
to
+73
| @@ -269,7 +270,7 @@ def test_version_mocked(mocker, Popen, stdout, expected): # noqa: N803 | ||
|
|
||
| assert version() == (1, 2, 3) | ||
| assert version() == expected |
There was a problem hiding this comment.
some of these patch changes seem like they should be upstreamed, did you want to open a PR against them and then just use fetchpatch to bring in those changes?
The nix-specific changes should stay in nixpkgs though.
There was a problem hiding this comment.
This patch has only nix-specific changes.
dotlambda
reviewed
May 29, 2020
| cp -r resources $out/${python.sitePackages}/ | ||
| ''; | ||
|
|
||
| # tests not included with PyPi Release |
There was a problem hiding this comment.
Can you ask the project to distribute them?
ryantm
added
2.status: merge conflict
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Closing due to inactivity from author. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adding popular diagrams package to draw cloud diagrams with python. In addition this PR upgrades the over 2 years old graphviz package.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)