Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swtpm: init at 0.3.1 #89143

Closed
wants to merge 2 commits into from
Closed

swtpm: init at 0.3.1 #89143

wants to merge 2 commits into from

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented May 29, 2020

Works as far as I can tell for the Windows VM I pulled up? Not sure how to explicitly test it.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danielfullmer
Copy link
Contributor

I've been recently been experimenting with adding a TPM to the nixos qemu VM tests using swtpm. These commits have been working for me thus far.

Lassulus
Lassulus reviewed Aug 22, 2020
View reviewed changes
pkgs/applications/virtualization/swtpm/default.nix
homepage = "https://github.com/stefanberger/swtpm";
license = licenses.bsd3;
platforms = platforms.linux;
maintainers = with maintainers; [ ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add yourself as a maintainer. adding packages without a maintainer is frowned upon

@eadwu eadwu closed this Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eadwu @danielfullmer @Lassulus