Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] gitAndTools.gh: 0.8.0 -> 0.9.0 #89148

Merged
merged 1 commit into from Jun 3, 2020
Merged

[20.03] gitAndTools.gh: 0.8.0 -> 0.9.0 #89148

merged 1 commit into from Jun 3, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented May 29, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit May 29, 2020 05:51
@kalbasit
Copy link
Member

I don't think that this fits the criteria for backporting. Does the update include security fixes?

@zowoq
Copy link
Contributor Author

zowoq commented May 29, 2020 •
edited

Not really "security" but it does have authentication fixes, I've been backporting all of the releases since it was added because their auth keeps changing.

kalbasit
kalbasit approved these changes May 30, 2020
View reviewed changes
Copy link
Member

@kalbasit kalbasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough!

@marsam marsam merged commit be20f1e into NixOS:release-20.03 Jun 3, 2020
@zowoq zowoq deleted the backport-gh branch June 3, 2020 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zowoq @kalbasit @marsam