Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] ffmpeg{_4,-full}, ffmpeg_2_8 #89149

Merged
merged 3 commits into from May 30, 2020
Merged

[20.03] ffmpeg{_4,-full}, ffmpeg_2_8 #89149

merged 3 commits into from May 30, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented May 29, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

zowoq added 3 commits May 29, 2020 15:37
(cherry picked from commit cfaa803)
(cherry picked from commit 0e38414)
(cherry picked from commit f7c914e)
@ofborg ofborg bot requested a review from codyopel May 29, 2020 05:53
@marsam marsam merged commit d124852 into NixOS:release-20.03 May 30, 2020
@zowoq zowoq deleted the backport-ffmpeg branch May 30, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants