Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bitbox02 #89119

Closed
wants to merge 5 commits into from
Closed

Add bitbox02 #89119

wants to merge 5 commits into from

Conversation

reardencode
Copy link
Contributor

@reardencode reardencode commented May 28, 2020 •
edited

Motivation for this change

Preparatory work for supporting BitBox02 in electrum whenever electrum 4.0 comes out.

Removes python2 support from block-io, streamlit, and zeronet, hopefully we're not caring about losing python2 support these days?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from nyanloutre and Rakesh4G May 28, 2020 18:12
jonringer
jonringer reviewed May 28, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

each package change should be it's own commit, I see 2 package additions, 1 bump, 1 modification, and one maintainer addition. so there should roughly be 5 commits

To comply with CONTRIBUTING.md please have the commit message name be of the format

<pkg-name>: <subject-line>

for more examples, please look at https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes

maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
@nyanloutre
Copy link
Member

@ofborg build python3Packages.block-io python3Packages.py-multihash zeronet streamlit

@reardencode
Copy link
Contributor Author

@nyanloutre I'm quite new to contributing to nixpkgs, is there a proper procedure for dropping python2 support from streamlit, zeronet, and block-io? I don't think anything changed for us with py-multihash

Thanks!

@reardencode
noiseprotocol: new python package
35701ab
@reardencode
py-multihash: Accept base58 >=2.0 as dependency
0e6dadc 
It looks like py-multihash depends on base58 < 2.0 because it wants to
support python3.4, but base58 2.0 supports python >= 3.5 only. This
doesn't effect nixpkgs because we don't have python3.4.
@reardencode
base58: Version bump
569a354
@reardencode
bitbox02: new python package
d704e89
prusnak
prusnak requested changes Nov 23, 2020
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reardencode Can you please rebase the PR, there are conflicts. While you are at it, please check whether some of the packages cannot be updated to even more recent versions. Finally, please prefix your commit messages with python3Packages. so it reads python3Packages.base58 instead of base58. Thanks!

@stale
Copy link

stale bot commented Jun 3, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak requested changes

@FRidh FRidh Awaiting requested review from FRidh

@nyanloutre nyanloutre Awaiting requested review from nyanloutre

@Rakesh4G Rakesh4G Awaiting requested review from Rakesh4G

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@reardencode @nyanloutre @prusnak @jonringer @ryantm