Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] haskellPackages.shh: Disable tests #89092

Merged
merged 1 commit into from May 28, 2020

Conversation

maralorn
Copy link
Member

(cherry picked from commit feb3b2d)

Motivation for this change

Backporting #89001 . Tests on stable also time out on hydra.

Things done

@cdepillabout
Copy link
Member

@GrahamcOfBorg build haskellPackages.shh

@cdepillabout
Copy link
Member

@maralorn Thanks for sending this PR.

Two things:

  • The correct branch is actually release-20.03 (not nixos-20.03). I realize this is confusing, and it seems like everyone is making this mistake recently.
  • You'll have to directly edit the pkgs/development/haskell-modules/hackage-packages.nix file and remove the broken = true; and hydraPlatforms = []; lines for shh. The process for doing this is different from the haskell-updates branch. It is not automated on the release branches.

@maralorn
Copy link
Member Author

maralorn commented May 28, 2020

* The correct branch is actually `release-20.03` (not `nixos-20.03`).  I realize this is confusing, and it seems like everyone is making this mistake recently.

I know that.^^ I just forgot.

* You'll have to directly edit the `pkgs/development/haskell-modules/hackage-packages.nix` file and remove the `broken = true;` and `hydraPlatforms = [];` lines for `shh`.  The process for doing this is different from the `haskell-updates` branch.  It is not automated on the release branches.

Well I already did that in #88719 . But I didn‘t realize at that time, that the tests are broken on hydra, that‘s why I unbroke a broken package.

(cherry picked from commit feb3b2d)
@cdepillabout
Copy link
Member

@maralorn Aahhh, sorry, I understand what happened.

Okay, this looks good, merging in. Thanks for backporting this.

@cdepillabout cdepillabout merged commit d55a904 into NixOS:release-20.03 May 28, 2020
@maralorn maralorn deleted the fix-shh-stable branch May 28, 2020 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants