Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/hydra
base: 7148923d306c
Choose a base ref
...
head repository: NixOS/hydra
compare: d5844897da55
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on May 28, 2020

  1. Set notificationpendingsince for dependent builds 

    `build_finished` Postgres event will never be fired for the dependent builds.

For example, on our Hydra, the following query always returns increasing
numbers, even though all notifications have been delivered:

```
hydra=> select count(1) from builds where notificationpendingsince is not null;
 count
-------
  4583
(1 row)
```

Thus, we have to iterate over all dependent builds and mark their
`notificationpendingsince` as `null`, otherwise they will pile up until
the next restart of hydra-notify, when they will get delivered.
    @knl
    knl committed May 28, 2020
    Copy the full SHA
    7d52946 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #771 from knl/fix-unprocessed-notificationpendings… 

    …ince

Fix: Set notificationpendingsince for dependent builds
    @edolstra
    edolstra committed May 28, 2020
    Copy the full SHA
    d584489 View commit details
    Browse the repository at this point in the history