Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade hplip & hplip plugin to 3.20.5 #89120

Merged
merged 1 commit into from Jun 15, 2020
Merged

Upgrade hplip & hplip plugin to 3.20.5 #89120

merged 1 commit into from Jun 15, 2020

Conversation

dasj19
Copy link
Contributor

@dasj19 dasj19 commented May 28, 2020

Motivation for this change

Version bump to the latest hplip.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from ttuegel May 28, 2020 18:23
flokli
flokli reviewed May 31, 2020
View reviewed changes
Copy link
Contributor

@flokli flokli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the commit message according to CONTRIBUTING.md.

@flokli
Copy link
Contributor

flokli commented Jun 15, 2020

Updated the commit message.

@flokli flokli merged commit fd2627b into NixOS:master Jun 15, 2020
@flokli flokli mentioned this pull request Jun 16, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli left review comments

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
9.needs: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dasj19 @flokli