python-language-server (Microsoft): enable on darwin #89150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: darwin
mjlbach
commented
May 29, 2020
|
|
||
| mkdir $out/bin | ||
| makeWrapper $out/lib/Microsoft.Python.LanguageServer $out/bin/python-language-server | ||
| ''; | ||
|
|
||
| postFixup = '' | ||
| postFixup = stdenv.lib.optionalString (!stdenv.hostPlatform.isDarwin) '' |
There was a problem hiding this comment.
I am very unsure if this is ok. These are dylibs on darwin and are bundled with python-language-server (not in these locations)
| @@ -0,0 +1,1321 @@ | |||
| # This file is autogenerated. | |||
There was a problem hiding this comment.
Also not happy about the level of duplication here, but I thought I'd start with the safest thing first.
mjlbach
changed the title
|
anyway we could get this merged in? |
|
@sorenmacbeth I don't think there are any blockers, not sure about the dylib situation as I noted in my comments. Also, of note, happy to get this merged but I now recommend using pyright as this language server has been abandoned by MS in favor of pyright/pylance |
|
@sorenmacbeth Pyright is already in Nixpkgs as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Closes #89139
Now that #88750 is merged adding dotnet core support, Microsoft's python language server ( #85930) should be able to be built on darwin. I'm not super familiar with packaging for nix on darwin. Definitely would appreciate any pointers or review.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)