Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php.buildEnv: Let enabled extensions to pass through by default #89132

Merged
merged 1 commit into from May 29, 2020
Merged

php.buildEnv: Let enabled extensions to pass through by default #89132

merged 1 commit into from May 29, 2020

Conversation

talyz
Copy link
Contributor

@talyz talyz commented May 28, 2020 •
edited

Motivation for this change

If only extraConfig is specified in buildEnv, keep the currently enabled extensions active. Brought up in #89011.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@talyz
php.buildEnv: Let enabled extensions to pass through by default
bfdc832 
If only extraConfig is specified in buildEnv, keep the currently
enabled extensions active. Brought up in NixOS#89011.
@talyz talyz requested a review from a team May 28, 2020 22:40
@talyz talyz mentioned this pull request May 28, 2020
Closed
@talyz talyz requested review from etu, globin, aanderse, shyim and Ma27 May 28, 2020 22:45
@Ma27 Ma27 merged commit 4eb9c62 into NixOS:master May 29, 2020
@talyz talyz deleted the php-buildenv-keep-extensions branch May 29, 2020 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@etu etu Awaiting requested review from etu

@globin globin Awaiting requested review from globin globin is a code owner

@aanderse aanderse Awaiting requested review from aanderse aanderse is a code owner

@shyim shyim Awaiting requested review from shyim

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@talyz @Ma27