Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

youtube-dl: 2020.05.08 -> 2020.05.29 #89131

Merged
merged 1 commit into from May 29, 2020
Merged

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented May 28, 2020

Motivation for this change

https://github.com/ytdl-org/youtube-dl/releases/tag/2020.05.29

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 merged commit 6da14c9 into NixOS:master May 29, 2020
@Luflosi Luflosi deleted the update/youtube-dl branch May 29, 2020 10:02
@Ma27
Copy link
Member

Ma27 commented May 29, 2020

Thanks! Also ported to stable: 6fe8bd0

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants