Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gitAndTools.gita and add bash completion #89085

Merged
merged 3 commits into from Jun 29, 2020
Merged

Update gitAndTools.gita and add bash completion #89085

merged 3 commits into from Jun 29, 2020

Conversation

wigust
Copy link
Contributor

@wigust wigust commented May 28, 2020

This package updates gitAndTools.gita and installs bash completion.

Motivation for this change

Missing bash completion for gita.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from seqizz May 28, 2020 07:13
seqizz
seqizz approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@seqizz seqizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the completion file is not in release tarballs. LGTM

@ofborg ofborg bot requested a review from seqizz June 2, 2020 19:46
seqizz
seqizz approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@seqizz seqizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested again, LGTM.

@ofborg ofborg bot requested a review from seqizz June 2, 2020 20:45
@wigust wigust requested a review from marsam June 29, 2020 05:12
@marsam marsam merged commit 79cd1cc into NixOS:master Jun 29, 2020
@marsam
Copy link
Contributor

marsam commented Jun 29, 2020

Sorry for the delay and thank you!

@wigust wigust deleted the gita branch June 30, 2020 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seqizz seqizz seqizz approved these changes

@marsam marsam Awaiting requested review from marsam

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wigust @marsam @seqizz