Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kdevelop: use LLVM 10 #89100

Merged
merged 1 commit into from May 30, 2020
Merged

kdevelop: use LLVM 10 #89100

merged 1 commit into from May 30, 2020

Conversation

glaebhoerl
Copy link
Contributor

@glaebhoerl glaebhoerl commented May 28, 2020

Motivation for this change

This fixes a bug: https://bugs.kde.org/show_bug.cgi?id=403484
The upstream also prefers LLVM 10: https://cgit.kde.org/kdevelop.git/tree/appimage/Dockerfile?h=5.5#n8

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I am a user of KDevelop and the bug indeed went away after making this change. I tested on 20.03 which is what I use.

@aanderse
Copy link
Member

How extensively have you tested this?

@glaebhoerl
Copy link
Contributor Author

I use KDevelop in my day job and it works better with this change than without it. Getting KDevelop to correctly highlight the C++ code at my workplace has always been a struggle, perhaps especially since I switched to NixOS, and it's still not perfect right now, so I can't say for completely certain whether the effects of the LLVM upgrade are 100% positive. In that respect I can only point again to the fact that there is an open bug report whose resolution is "don't use LLVM 7", and that upstream themselves use LLVM 10 in their AppImage, which I assume would mean that they have tested it extensively enough.

They also seem to have skipped over LLVM 7 entirely, suggesting it might be a uniquely bad version to use: https://cgit.kde.org/kdevelop.git/commit/appimage/Dockerfile?h=5.5&id=1a68e1e97bdbaf81c714dd11a3da9c06d4d84b4a

@aanderse
Copy link
Member

Sounds good. I tried it out and I don't notice any major regressions. Thanks!

@aanderse aanderse merged commit 2a16738 into NixOS:master May 30, 2020
@glaebhoerl glaebhoerl deleted the patch-3 branch May 30, 2020 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants