Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spotify-tui: 0.19.0 -> 0.20.0 #89102

Merged
merged 1 commit into from May 28, 2020
Merged

spotify-tui: 0.19.0 -> 0.20.0 #89102

merged 1 commit into from May 28, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented May 28, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from jwijenbergh May 28, 2020 11:09
Kloenk
Kloenk approved these changes May 28, 2020
View reviewed changes
Copy link
Member

@Kloenk Kloenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the versions are updated. The new versions are building on my system. So I think its good to go.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/164

jwijenbergh
jwijenbergh approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@jwijenbergh jwijenbergh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@marsam marsam merged commit edc63ad into NixOS:master May 28, 2020
@marsam marsam deleted the update-spotify-tui branch May 28, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kloenk Kloenk Kloenk approved these changes

@jwijenbergh jwijenbergh jwijenbergh approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marsam @nixos-discourse @Kloenk @jwijenbergh