Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/maintainers/scripts/ec2/create-amis.sh: fix argument check #89116

Merged
merged 1 commit into from Aug 22, 2020
Merged

nixos/maintainers/scripts/ec2/create-amis.sh: fix argument check #89116

merged 1 commit into from Aug 22, 2020

Conversation

wagdav
Copy link
Contributor

@wagdav wagdav commented May 28, 2020

Motivation for this change

Because the script ./nixos/maintainers/scripts/ec2/create-amis.sh uses set -u when no arguments are provided bash exits with the error:

$1: unbound variable

instead of the printing the helpful usage message.

Things done

I ran the script without arguments and now it prints the usage.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wagdav
create-amis: fix argument check
3b1ed03 
Because this script enables `set -u` when no arguments are provided bash
exits with the error:

    $1: unbound variable

instead of the helpful usage message.
@Lassulus Lassulus merged commit d08b81c into NixOS:master Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wagdav @Lassulus @Janik-Haag