Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metals: provide client-agnostic flavor #89115

Merged
merged 1 commit into from May 28, 2020

Conversation

timokau
Copy link
Member

@timokau timokau commented May 28, 2020

Motivation for this change

I want to configure metals with the neovim builtin lsp. I get the impression that metals.client is more or less a legacy setting since now clients can directly communicate their feature support to metals.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau timokau requested a review from ceedubs May 28, 2020 15:46
@timokau
Copy link
Member Author

timokau commented May 28, 2020

CC @Tomahna (for some reason I can't directly request a review, maybe you didn't accept the maintainers team invite)

@timokau
Copy link
Member Author

timokau commented May 28, 2020

See for example https://scalameta.org/metals/docs/editors/new-editor.html, which doesn't mention metals.client at all.

@timokau
Copy link
Member Author

timokau commented May 28, 2020

Looks like this option is relatively recent: scalameta/metals#1626. Also a somewhat related discussion: scalameta/metals#1413.

@Tomahna
Copy link
Contributor

Tomahna commented May 28, 2020

LGTM, it seems to work well with emacs too even though lsp-mode has not been updated yet to use the client-agnostic command.

@timokau timokau merged commit d6cf34e into NixOS:master May 28, 2020
@timokau timokau deleted the metals-client-agnostic branch May 28, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants