Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

colormake: use fetchFromGitHub #89137

Merged
merged 1 commit into from May 31, 2020
Merged

colormake: use fetchFromGitHub #89137

merged 1 commit into from May 31, 2020

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented May 29, 2020

Verified the sha256 does not change.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
Copy link
Contributor Author

bhipple commented May 29, 2020

Result of nixpkgs-review pr 89137 1

1 package built:
- colormake

@bhipple
colormake: use fetchFromGitHub
a25bdf1 
Verified the sha256 does not change.
@flokli flokli merged commit 98ed9c3 into NixOS:master May 31, 2020
@bhipple bhipple deleted the fix/colormake branch June 2, 2020 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexarice alexarice alexarice left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bhipple @alexarice @flokli