Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oniguruma: switch to autotools #89141

Merged
merged 1 commit into from May 29, 2020
Merged

oniguruma: switch to autotools #89141

merged 1 commit into from May 29, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented May 29, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @vcunat

vcunat
vcunat approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why this change fixes the pkgsi686Linux.jq tests?

@vcunat vcunat added the 1.severity: channel blocker Blocks a channel label May 29, 2020
@zowoq
Copy link
Contributor Author

zowoq commented May 29, 2020

Any idea why this change fixes the pkgsi686Linux.jq tests?

No. I was looking to see if anyone else had encountered this and noticed that no one else seems to be using a cmake build and upstream doesn't really mention it.

@vcunat vcunat merged commit 135073a into NixOS:master May 29, 2020
@zowoq zowoq deleted the oniguruma branch May 29, 2020 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
1.severity: channel blocker Blocks a channel 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zowoq @vcunat