legendary-gl: init at 0.0.14 #89142
Merged
legendary-gl: init at 0.0.14 #89142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! So far I tried
All worked no problem - I'm now just waiting for a download to complete. Due to the quality of my current internet connection it might take a while but will report back as soon as that's complete. I'm not however familiar with Python packaging so can't really offer any comments on the expression itself. |
prusnak
requested changes
May 30, 2020
prusnak
requested changes
May 30, 2020
* Adds requested launcher for EPIC games * Fix NixOS#88963
prusnak
approved these changes
May 31, 2020
|
Sorry for the late response - tested this so far with a single game and all steps worked fine though launching required providing a shell that included |
pbogdan
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
I have started up the binary and authenticated with an empty account. Because I don't own any EPIC games, I couldn't test any of the
realfunctionality, but login works, at least.sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)