-
Notifications
You must be signed in to change notification settings - Fork 69
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c32246e61cf9
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a9d5e414f1e2
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 2 commits
- 2 files changed
- 2 contributors
Commits on May 26, 2020
-
Fix linker error when compiling with clang 9+
Clang 9 changed the linkage definition for variable templates with const-qualified type (see llvm/llvm-project@bb75068). This leads to the following linker error in "make test" when compiling with clang versions >= 9: clang++ -c -std=c++1z -stdlib=libc++ -O3 -g -fPIC -fexceptions -ferror-limit=1000 -fno-omit-frame-pointer -Wall -Wpedantic -Wno-char-subscripts -Wno-gnu-anonymous-struct -Wno-gnu-zero-variadic-macro-arguments -Wno-nested-anon-types -Wno-unknown-pragmas -DPROJECT_DIR='std::filesystem::path("ksp_plugin_adapter/")' -DSOLUTION_DIR='std::filesystem::path("./")' -DTEMP_DIR='std::filesystem::path("/tmp")' -DNDEBUG -m64 -I. -Ideps/glog/src -Ideps/protobuf/src -Ideps/gipfeli/include -Ideps/abseil-cpp -Ideps/zfp/include base/version.generated.cc -o obj/base/version.generated.o clang++ -std=c++1z -stdlib=libc++ -O3 -g -fPIC -fexceptions -ferror-limit=1000 -fno-omit-frame-pointer -Wall -Wpedantic -Wno-char-subscripts -Wno-gnu-anonymous-struct -Wno-gnu-zero-variadic-macro-arguments -Wno-nested-anon-types -Wno-unknown-pragmas -DPROJECT_DIR='std::filesystem::path("ksp_plugin_adapter/")' -DSOLUTION_DIR='std::filesystem::path("./")' -DTEMP_DIR='std::filesystem::path("/tmp")' -DNDEBUG -m64 obj/tools/generate_configuration.o obj/tools/generate_kopernicus.o obj/tools/generate_profiles.o obj/tools/journal_proto_processor.o obj/tools/main.o obj/serialization/astronomy.pb.o obj/serialization/geometry.pb.o obj/serialization/integrators.pb.o obj/serialization/journal.pb.o obj/serialization/ksp_plugin.pb.o obj/serialization/numerics.pb.o obj/serialization/physics.pb.o obj/serialization/quantities.pb.o obj/serialization/testing_utilities.pb.o obj/numerics/cbrt.o obj/numerics/elliptic_functions.o obj/numerics/elliptic_integrals.o obj/numerics/fast_sin_cos_2π.o obj/base/version.generated.o deps/protobuf/src/.libs/libprotobuf.a deps/gipfeli/libgipfeli.a deps/abseil-cpp/absl/strings/libabsl_strings.a deps/abseil-cpp/absl/synchronization/libabsl_synchronization.a deps/abseil-cpp/absl/time/libabsl_*.a deps/abseil-cpp/absl/debugging/libabsl_*.a deps/abseil-cpp/absl/numeric/libabsl_*.a deps/abseil-cpp/absl/base/libabsl_*.a deps/zfp/build/lib/libzfp.a deps/glog/.libs/libglog.a -lpthread -lc++ -lc++abi -lsupc++ -lc++fs -o bin/tools /usr/bin/ld: obj/tools/generate_kopernicus.o:(.rodata+0x8): multiple definition of `principia::quantities::si::Unit<double>'; obj/tools/generate_configuration.o:(.rodata+0x8): first defined here /usr/bin/ld: obj/tools/generate_kopernicus.o:(.rodata+0x0): multiple definition of `principia::base::internal_traits::all_different_v<>'; obj/tools/generate_configuration.o:(.rodata+0x0): first defined here /usr/bin/ld: obj/tools/main.o:(.rodata+0x8): multiple definition of `principia::quantities::si::Unit<double>'; obj/tools/generate_configuration.o:(.rodata+0x8): first defined here /usr/bin/ld: obj/tools/main.o:(.rodata+0x0): multiple definition of `principia::base::internal_traits::all_different_v<>'; obj/tools/generate_configuration.o:(.rodata+0x0): first defined here /usr/bin/ld: obj/numerics/elliptic_functions.o:(.rodata+0x8): multiple definition of `principia::quantities::si::Unit<double>'; obj/tools/generate_configuration.o:(.rodata+0x8): first defined here /usr/bin/ld: obj/numerics/elliptic_functions.o:(.rodata+0x0): multiple definition of `principia::base::internal_traits::all_different_v<>'; obj/tools/generate_configuration.o:(.rodata+0x0): first defined here /usr/bin/ld: obj/numerics/elliptic_integrals.o:(.rodata+0x8): multiple definition of `principia::quantities::si::Unit<double>'; obj/tools/generate_configuration.o:(.rodata+0x8): first defined here /usr/bin/ld: obj/numerics/elliptic_integrals.o:(.rodata+0x0): multiple definition of `principia::base::internal_traits::all_different_v<>'; obj/tools/generate_configuration.o:(.rodata+0x0): first defined here /usr/bin/ld: obj/numerics/fast_sin_cos_2π.o:(.rodata+0x18): multiple definition of `principia::quantities::si::Unit<double>'; obj/tools/generate_configuration.o:(.rodata+0x8): first defined here /usr/bin/ld: obj/numerics/fast_sin_cos_2π.o:(.rodata+0x10): multiple definition of `principia::base::internal_traits::all_different_v<>'; obj/tools/generate_configuration.o:(.rodata+0x0): first defined here Adding "inline" to the definitions for principia::quantities::si::Unit<double> and principia::base::internal_traits::all_different_v<> fixes this error.
Configuration menu - View commit details
-
Copy full SHA for 3ce89a7 - Browse repository at this point
Copy the full SHA 3ce89a7View commit details
Commits on May 28, 2020
-
Merge pull request #2592 from rkunze/fix-compile-with-clang-9+
Fix linker error when compiling with clang 9+
Configuration menu - View commit details
-
Copy full SHA for a9d5e41 - Browse repository at this point
Copy the full SHA a9d5e41View commit details
There are no files selected for viewing