Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gap: cleanup #89111

Merged
merged 7 commits into from Jun 2, 2020
Merged

gap: cleanup #89111

merged 7 commits into from Jun 2, 2020

Conversation

timokau
Copy link
Member

@timokau timokau commented May 28, 2020

Motivation for this change

Various cleanups suggested by upstream (Max Horn).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

As suggested by Max Horn.

This exists since gap 4.10 and will only run the install checks once
while also exiting with an appropriate exit code. This new check has
uncovered some test failures, which are harmless and actually disabled
in a future gap release. The error-detection code for the previous test
target was probably broken.
GAP downloads moved to a new subdomain. The old one still redirects, but
the new one is the "source of truth" so we should switch to that.
No longer necessary, since the build system was significantly overhauled
/ replaced by Max Horn.
Technically optional but strongly recommended from upstream. Replaces
their own implementation for input parsing.
System gmp is now the default.
@timokau timokau merged commit 374016f into NixOS:master Jun 2, 2020
@timokau timokau deleted the gap-cleanup branch June 2, 2020 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants