Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: docking tiles cache check #8120

Merged
merged 1 commit into from May 6, 2020
Merged

Add: docking tiles cache check #8120

merged 1 commit into from May 6, 2020

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented May 6, 2020

Not tested, but I think that should help

@LordAro
Copy link
Member

LordAro commented May 6, 2020

worth wrapping it in a #ifndef NDEBUG perhaps?

@Yexo
Copy link
Contributor

Yexo commented May 6, 2020

worth wrapping it in a #ifndef NDEBUG perhaps?

This code is inside CheckCaches() which quickly returns if _debug_desync_level<=1. That should be enough.

@Yexo
Copy link
Contributor

Yexo commented May 6, 2020

Verified that this catches the desync from #8119.

Yexo
Yexo previously approved these changes May 6, 2020
@glx22 glx22 merged commit 86e9326 into OpenTTD:master May 6, 2020
@glx22 glx22 deleted the docking_check branch May 6, 2020 23:14
@glx22 glx22 added the backport requested This PR should be backport to current release (RC / stable) label May 6, 2020
LordAro pushed a commit to LordAro/OpenTTD that referenced this pull request May 10, 2020
LordAro pushed a commit that referenced this pull request Jun 1, 2020
@LordAro LordAro added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants