Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/{modules,tests}/teeworlds: init #87178

Merged
merged 1 commit into from Jun 12, 2020
Merged

nixos/{modules,tests}/teeworlds: init #87178

merged 1 commit into from Jun 12, 2020

Conversation

hax404
Copy link
Contributor

@hax404 hax404 commented May 7, 2020

Motivation for this change

add module and test for Teeworlds based on the OpenArena module and test

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hax404 hax404 force-pushed the teeworlds-module-test branch 2 times, most recently from aec19ea to 9553c1d Compare May 23, 2020 22:04
@hax404
Copy link
Contributor Author

hax404 commented Jun 6, 2020

resolved race condition in the test and rebased on master

@hax404 hax404 requested a review from astsmtl June 12, 2020 16:09
@Mic92
Copy link
Member

Mic92 commented Jun 12, 2020

Will have a look.

Mic92
Mic92 reviewed Jun 12, 2020
View reviewed changes
nixos/tests/teeworlds.nix

server.sleep(10) # wait for a while to get a nice screenshot

client1.screenshot("screen_client1")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this part.

@Mic92 Mic92 merged commit 8df5edc into NixOS:master Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@mweinelt mweinelt mweinelt approved these changes

@astsmtl astsmtl Awaiting requested review from astsmtl

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hax404 @Mic92 @mweinelt