Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brave: 1.7.92 -> 1.8.90 #87162

Closed
wants to merge 1 commit into from
Closed

brave: 1.7.92 -> 1.8.90 #87162

wants to merge 1 commit into from

Conversation

charles-dyfis-net
Copy link
Contributor

Motivation for this change

Package update. Security fixes, bugfixes, etc.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

bbjubjub2494
bbjubjub2494 reviewed May 7, 2020
View reviewed changes
Copy link
Member

@bbjubjub2494 bbjubjub2494 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds fine, appears to work fine (I'm a Brave user)

pkgs/applications/networking/browsers/brave/default.nix
@@ -29,6 +30,7 @@
, libXrender
, libXScrnSaver
, libXtst
, mesa_drivers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should make OfBorg happy without affecting the actual derivation (assuming that's required) (1/2)

Suggested change
, mesa_drivers
, mesa

pkgs/applications/networking/browsers/brave/default.nix
@@ -69,6 +72,7 @@ rpath = lib.makeLibraryPath [
libXrender
libXtst
libuuid
mesa_drivers.out # libgbm.so
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2/2

Suggested change
mesa_drivers.out # libgbm.so
mesa.drivers.out # libgbm.so

@bbjubjub2494
Copy link
Member

superseded by #87277 assuming it gets merged

@puzzlewolf
Copy link
Contributor

I guess this can be closed, #87277 was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbjubjub2494 bbjubjub2494 bbjubjub2494 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@charles-dyfis-net @bbjubjub2494 @puzzlewolf