Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Damien/riot 1.6 #87135

Closed
wants to merge 2 commits into from
Closed

Conversation

DamienCassou
Copy link
Contributor

@DamienCassou DamienCassou commented May 6, 2020

Motivation for this change

New version of riot:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member

Ma27 commented May 6, 2020

Already done in bc6bad2, b978747

@Ma27 Ma27 closed this May 6, 2020
@DamienCassou
Copy link
Contributor Author

Result of nixpkgs-review pr 87135 1

@DamienCassou
Copy link
Contributor Author

@Ma27 I haven't seen any PR including these commits. Were they pushed directly to the master branch?

@DamienCassou DamienCassou deleted the damien/riot-1.6 branch May 6, 2020 20:32
@Ma27
Copy link
Member

Ma27 commented May 6, 2020

Yes. Was a fairly trivial update of a leaf-package :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants