nixos/nano: extend configuration-options #87192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sivizius
changed the title
More options for /etc/nanorc (all except syntax-highlighting).
nano2 was used while testing, but it should be nano.
›the nixos-rebuid‹ → ›nixos-rebuild‹
Corrected/updated some descriptions (typos, formarting, …).
|
Hi @sivizius thanks for the contribution. This was a 42 line module... almost 1,000 now 😱 I feel like it would take me longer to understand how to write a configuration using this module than it would to use the </opinion> What do you think? |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
@sivizius friendly ping |
stale
bot
removed
the
2.status: stale
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Closed due to No response from OP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
To have more options of /etc/nanorc implemented in pure nix.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/) – there are no exutables involvednix path-info -Sbefore and after)This just modifies /etc/nanorc configuration and the generated nanorc-file looks ok and nano does not complain at start, so I guess it is fine.