Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/nano: extend configuration-options #87192

Closed
wants to merge 4 commits into from
Closed

nixos/nano: extend configuration-options #87192

wants to merge 4 commits into from
+937 −10

Conversation

sivizius
Copy link
Contributor

@sivizius sivizius commented May 7, 2020 •
edited
Loading

Motivation for this change

To have more options of /etc/nanorc implemented in pure nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions – afaik on all systems nano looks only at /etc/nanorc (or .nanorc, but that is something for home-manager), therefore, this should work on every system.
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/) – there are no exutables involved
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This just modifies /etc/nanorc configuration and the generated nanorc-file looks ok and nano does not complain at start, so I guess it is fine.

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels May 7, 2020
@sivizius sivizius changed the title Better nano-options nano: extend configuration-options May 7, 2020
@sivizius sivizius changed the title nano: extend configuration-options nixos/nano: extend configuration-options May 7, 2020
sivizius added 4 commits May 7, 2020 16:16
@sivizius
nixos/nano: extend configuration-options
f20ebf0 
More options for /etc/nanorc (all except syntax-highlighting).
@sivizius
nixos/nano: nano2 → nano
8af659e 
nano2 was used while testing, but it should be nano.
@sivizius
nixos/nano: fixed typo
3ea312f 
›the nixos-rebuid‹ → ›nixos-rebuild‹
@sivizius
nixos/nano: Updated Descriptions
1295fb2 
Corrected/updated some descriptions (typos, formarting, …).
@aanderse
Copy link
Member

aanderse commented May 7, 2020

Hi @sivizius thanks for the contribution. This was a 42 line module... almost 1,000 now 😱 I feel like it would take me longer to understand how to write a configuration using this module than it would to use the nanorc option with man pages. Maybe an attribute set would be a nice compromise between simple module logic and a more structured configuration format 🤔

</opinion>

What do you think?

@stale
Copy link

stale bot commented Nov 4, 2020

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 4, 2020
@SuperSandro2000
Copy link
Member

@sivizius friendly ping

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 25, 2020
@stale
Copy link

stale bot commented Jun 3, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2021
@doronbehar doronbehar closed this Aug 7, 2021
@doronbehar
Copy link
Contributor

Closed due to No response from OP.

@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sivizius @aanderse @SuperSandro2000 @doronbehar @Janik-Haag