Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php: correctly set outputsToInstall after withExtensions. #87138

Merged
merged 1 commit into from May 9, 2020
Merged

php: correctly set outputsToInstall after withExtensions. #87138

merged 1 commit into from May 9, 2020

Conversation

lukegb
Copy link
Contributor

@lukegb lukegb commented May 6, 2020

Motivation for this change

At the moment, using .withExtensions on a PHP derivation will produce something which can't be used inside an environment.systemPackages array, because meta.outputsToInstall refers to an output which doesn't exist on the final wrapping derivation.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lukegb
php: override outputsToInstall when using withExtensions
c13df54 
At the moment, using .withExtensions on a PHP derivation will
produce something which can't be used inside an
environment.systemPackages array, because outputsToInstall refers
to an output which doesn't exist on the final derivation.

Instead, override it back to just containing the single output
"out".
@lukegb lukegb requested a review from etu as a code owner May 6, 2020 20:45
@adisbladis adisbladis merged commit 2e69f89 into NixOS:master May 9, 2020
@lukegb lukegb deleted the fix-php branch May 9, 2020 13:42
@LnL7 LnL7 mentioned this pull request May 10, 2020
Closed
@Ma27 Ma27 mentioned this pull request May 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu Awaiting requested review from etu

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lukegb @adisbladis @Janik-Haag