Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leak: All incoming admin port packets leaked #8117

Closed
JGRennison opened this issue May 6, 2020 · 0 comments
Closed

Memory leak: All incoming admin port packets leaked #8117

JGRennison opened this issue May 6, 2020 · 0 comments

Comments

@JGRennison
Copy link
Contributor

Version of OpenTTD

33ed4dd to 64278fd

Expected result

Incoming admin port packets are not leaked

Actual result

Incoming admin port packets are leaked

Steps to reproduce

Use the admin port, leaks can be detected using tools such as AddressSanitiser.

NetworkAdminSocketHandler::ReceivePackets() does not delete packets returned from NetworkTCPSocketHandler::ReceivePacket().

The corresponding leak for game sockets was fixed in 374fc30.
glx22 added a commit to glx22/OpenTTD that referenced this issue May 6, 2020
@glx22
Fix OpenTTD#8117: memory leak in admin port
87c3d13
glx22 added a commit to glx22/OpenTTD that referenced this issue May 6, 2020
@glx22
Fix OpenTTD#8117: Memory leak in admin port
fd93b89
@glx22 glx22 closed this as completed in 82573a5 May 7, 2020
LordAro pushed a commit to LordAro/OpenTTD that referenced this issue May 10, 2020
@glx22 @LordAro
Fix OpenTTD#8117: Memory leak in admin port (OpenTTD#8122)
209dd11
LordAro pushed a commit that referenced this issue Jun 1, 2020
@glx22 @LordAro
Fix #8117: Memory leak in admin port (#8122)
cf27deb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JGRennison