Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot rebuild just buildozed dock #8121

Closed
Yexo opened this issue May 6, 2020 · 4 comments
Closed

Cannot rebuild just buildozed dock #8121

Yexo opened this issue May 6, 2020 · 4 comments
Labels
bug Something isn't working
Milestone

Comments

@Yexo
Copy link
Contributor

Yexo commented May 6, 2020

Version of OpenTTD

1.10.1, also head as of bc83337

Expected result

When buildozing a dock, it's possible to rebuild immediately.

Actual result

Cannot rebuild in some scenarios.

Steps to reproduce

Load savegame from #8119, delete dock from Benfingford Docks. Try to rebuild it. Get "...site unsuitable error".

Comments from frosch on irc:
yes, that's an old issue
it was like that in ttd, since ships headed to the tile in line with the dock
but apparently IsValidDockingDirectionForDock now does the opposite
so the builddock check should be changed as well

@SamuXarick
Copy link
Contributor

If you're going to change that, it will break some AIs that rely on that behaviour. They may end up building docks that will be blocking some paths and ships get lost.

@Yexo
Copy link
Contributor Author

Yexo commented May 7, 2020

Please start fixing those AIs now rather than later. Given that nobody has complained about this, it probably isn't a high priority fix nor will a backport to 1.10 be required, but imo potentially breaking some AIs is not a reason not to fix this for 1.11.

@TrueBrain TrueBrain added the bug Something isn't working label Jan 1, 2021
@TrueBrain TrueBrain modified the milestone: 1.11.0 Jan 5, 2021
@TrueBrain
Copy link
Member

TrueBrain commented Jan 7, 2021

Is this really a bug? I mean, I found other ways to build a dock, terraform, and no longer being able to build the dock if I removed it. It is a bit how dock building works .. it expects the second tile out from where you place also to be valid, but it is easy to create cases after the fact where it no longer is valid. As example:

image

There is never going to be a way anymore that I can rebuild that dock if I remove it.

I can, however, imagine it is a bug that you cannot build a dock in the following situation (it currently is not):

image

But that has nothing to do with rebuilding ofc :)

Looking for input here, what is expected behaviour :)

@TrueBrain
Copy link
Member

How it currently stands, this is fully intended behaviour.

With the changes to docks, an argument can be made the "3rd tile" restriction of docks can be lifted, which would also resolve this problem, but that is something for another day.

Going to close this issue, as "as intended". Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants