rustPlatform: fix bug with ambiguous diff tool #87155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user provides `nativeBuildInputs = [ llvmPackages.bintools ]` or any other
package containing a `${prefix}/bin/diff`, the builder could use it instead
of the standard unix `diff`, causing a build failure.
This updates the call to specify an abspath to `diff` and avoid reliance on `PATH`.
Resolves NixOS#87081
|
@GrahamcOfBorg build ripgrep |
ofborg
bot
added
6.topic: rust
10.rebuild-darwin: 101-500
10.rebuild-linux: 101-500
labels
jonringer
approved these changes
May 7, 2020
zimbatm
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user provides
nativeBuildInputs = [ llvmPackages.bintools ]or any otherpackage containing a
${prefix}/bin/diff, the builder could use it insteadof the standard unix
diff, causing a build failure.This updates the call to specify an abspath to
diffand avoid reliance onPATH.Resolves #87081