Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssm-session-manager-plugin: init at 1.1.61.0 #87165

Merged
merged 1 commit into from May 8, 2020
Merged

ssm-session-manager-plugin: init at 1.1.61.0 #87165

merged 1 commit into from May 8, 2020

Conversation

martinbaillie
Copy link
Contributor

Motivation for this change

This PR introduces the AWS SSM Session Manager Plugin, a necessary proprietary binary for client machines wishing to utilise the AWS CLI aws ssm start-session subcommand to connect to EC2 instances. An SSM Session is a secure interactive shell proxied via Amazon's APIs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

ssm-session-manager-plugin: init at 1.1.61.0
9566c74 
Signed-off-by: Martin Baillie <martin@baillie.email>
@ryantm
Copy link
Member

ryantm commented May 8, 2020

Result of nixpkgs-review pr 87165 1

1 package built:
- ssm-session-manager-plugin

@ryantm ryantm merged commit 2065af7 into NixOS:master May 8, 2020
@martinbaillie martinbaillie mentioned this pull request May 8, 2020
Merged
@socksy
Copy link

socksy commented May 12, 2020

Is this the same as #73825? Should I now close that?

@ryantm
Copy link
Member

ryantm commented May 12, 2020

@martijnvermaat @socksy We should consider renaming this to "aws-session-manager-plugin" to match with the AUR. https://repology.org/projects/?search=session-manager-plugin

@ryantm
Copy link
Member

ryantm commented May 12, 2020

@socksy Sorry, I didn't notice that PR was already open when I merged this one; I closed yours. I'd appreciate if you add yourself as a maintainer!

@martinbaillie
Copy link
Contributor Author

My apologies. I hastily searched nixpkgs master but didn't think to check for old PRs.

I can do the work to rename to match AUR and also edit maintainers to add you @socksy (if that's ok?)

@socksy
Copy link

socksy commented May 12, 2020

Sure, you can add me if you like :) I'm a bit of a noob with these packages though.

@ryantm
Copy link
Member

ryantm commented May 12, 2020

@socksy Thanks! Just being able to test the latest version is super helpful.

@martinbaillie
Copy link
Contributor Author

PR for updated package name: #87707

@lexun lexun mentioned this pull request Jun 10, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@martinbaillie @ryantm @socksy